Use weak self captures in background Tasks#77
Open
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Open
Use weak self captures in background Tasks#77zmanian wants to merge 1 commit intomcintyre94:mainfrom
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Conversation
Prevent potential retain cycles by capturing self weakly in fire-and-forget Tasks for checkpoints, WispAsk answers, and upload result dismissal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[weak self]to auto-checkpoint Task inChatViewModel.processStreamEvent(was capturing self strongly viaself.createAutoCheckpoint)[weak self]to manual checkpoint Task increateCheckpoint(for:modelContext:)[weak self]tosubmitWispAskAnswerTask[weak self]to upload result dismissal Task inSpriteOverviewViewModelThese Tasks are fire-and-forget (not stored or cancelled), so if the view model is deallocated while they're running, they would keep it alive unnecessarily. With
[weak self], they gracefully bail out.Test plan
Generated with Claude Code