Improve error handling for keychain and auto-checkpoints#78
Open
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Open
Improve error handling for keychain and auto-checkpoints#78zmanian wants to merge 1 commit intomcintyre94:mainfrom
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Conversation
- KeychainService.delete now returns success/failure status - Auto-checkpoint failures surface as a transient error status instead of being silently logged Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeychainService.deletenow returns aBoolindicating success/failure (previously returnedVoidand silently ignoredSecItemDeleteerrors). Marked@discardableResultso existing callers don't need changes..errorstatus instead of being silently logged. Previously, if checkpoint creation failed repeatedly, the user had no visibility.Test plan
Generated with Claude Code