Reuse shared JSONDecoder instances instead of allocating per call#79
Open
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Open
Reuse shared JSONDecoder instances instead of allocating per call#79zmanian wants to merge 1 commit intomcintyre94:mainfrom
zmanian wants to merge 1 commit intomcintyre94:mainfrom
Conversation
SpritesAPIClient stream methods now use the existing instance decoder. GitHubAPIClient shares a single static decoder across all decode sites. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpritesAPIClient: The three streaming methods (streamService,streamServiceLogs,streamingRequest) were each creating a newJSONDecoder()per call. Now they use the existingself.decoderinstance property.GitHubAPIClient: Four decode sites were each creating a newJSONDecoder(). Added a sharedstatic let jsonDecoderand use it throughout.JSONDecoder allocation is lightweight, but when streaming hundreds of NDJSON events per chat session, reusing a single decoder avoids unnecessary allocations.
Test plan
Generated with Claude Code