fix(ci): enforce PR checklist completion with evidence links#368
Merged
fix(ci): enforce PR checklist completion with evidence links#368
Conversation
- Change DangerJS Rule 5b from warn to fail for missing evidence links - Create PR template with required evidence format examples - Add PR Evidence Requirements section to CONTRIBUTING.md - Reference exemplar PR #263 for proper evidence format Refs: #290 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
martincjarvis
approved these changes
Jan 15, 2026
Collaborator
martincjarvis
left a comment
martincjarvis
left a comment
There was a problem hiding this comment.
QA Approval
Verification
- DangerJS blocks unchecked items (verified: Rule 5a uses
fail) - DangerJS fails on missing evidence (verified: Rule 5b changed from
warntofail) - PR template created with evidence format examples
- CONTRIBUTING.md has "PR Evidence Requirements" section
- All CI checks pass
- DangerJS enforcement working (this PR itself was blocked until evidence added)
Test of New Rule
The new enforcement rule successfully blocked this PR until proper evidence links were added - demonstrating the rule works as intended.
Approved for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
warntofailfor missing evidence links.github/PULL_REQUEST_TEMPLATE.md) with required evidence formatCloses #290
Test plan
🤖 Generated with Claude Code