fix(ci): require substantive code review comments#369
Merged
Conversation
- Add DangerJS Rule 8 to warn on brief/empty approval reviews (<50 chars) - Add "For Reviewers" section to PR template with guidance - Add "Code Review Guidelines" section to CONTRIBUTING.md with exemplar Refs: #291 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
martincjarvis
approved these changes
Jan 15, 2026
Collaborator
martincjarvis
left a comment
martincjarvis
left a comment
There was a problem hiding this comment.
QA Review - Code Review Depth Enforcement
Files reviewed: dangerfile.js, PULL_REQUEST_TEMPLATE.md, CONTRIBUTING.md
Verification
dangerfile.js (Rule 8):
- Correctly filters for APPROVED reviews only
- MIN_REVIEW_BODY_LENGTH of 50 chars is reasonable threshold
- Only warns if ALL approvals are brief (allows mixed quality)
- Clear warning message explains what's needed
PR Template:
- "For Reviewers" section provides clear guidance
- Example approval comment demonstrates expected format
- Placed appropriately at bottom (doesn't interfere with author sections)
CONTRIBUTING.md:
- Code Review Guidelines section clearly explains requirements
- Exemplar review format is practical and achievable
- Blockquote exemplar is realistic and demonstrates good practice
Potential Edge Cases Checked
- Empty reviews array: Handled (guard
approvedReviews.length > 0) - Reviews with only whitespace: Handled (
body.trim().length) - Mixed quality reviews: Only warns if ALL are brief
Descoped Item
Confirmed: "Code review skill updated" correctly descoped since requesting-code-review is in superpowers, not this repo.
Approved - no blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #291
Test plan
🤖 Generated with Claude Code