fix(process): enforce plan approval before implementation#370
Merged
martincjarvis merged 1 commit intomainfrom Jan 15, 2026
Merged
fix(process): enforce plan approval before implementation#370martincjarvis merged 1 commit intomainfrom
martincjarvis merged 1 commit intomainfrom
Conversation
Add automated enforcement for plan approval workflow: - DangerJS Rule 9: warns when linked issue lacks plan comment or approval - Updated skill-spec.md issue template with Plan Approval section - Created general-issue.md template with Plan Approval section - Updated issue-driven-delivery skill with Automated Enforcement section - Added Plan Approval Workflow section to CONTRIBUTING.md - Referenced Issue #177 as workflow exemplar Refs: #292 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mcj-coder
approved these changes
Jan 15, 2026
Owner
mcj-coder
left a comment
mcj-coder
left a comment
There was a problem hiding this comment.
Reviewed dangerfile.js, CONTRIBUTING.md, skill-spec.md, general-issue.md, and issue-driven-delivery SKILL.md.
Verification:
- isPlanComment() function correctly identifies plan comments by header, docs/plans link, or approval language
- isApprovalComment() function detects multiple approval patterns
- Rule 9 uses warn() not fail() which is appropriate for initial rollout
- Issue templates have consistent Plan Approval section format
- CONTRIBUTING.md Plan Approval Workflow section matches skill documentation
- Issue #177 exemplar reference is consistent across all files
No concerns found. Logic is correct and non-breaking. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #292
Test plan
For Reviewers
Reviewed files: dangerfile.js, .github/ISSUE_TEMPLATE/skill-spec.md, .github/ISSUE_TEMPLATE/general-issue.md, skills/issue-driven-delivery/SKILL.md, CONTRIBUTING.md
Key verification points:
🤖 Generated with Claude Code