Skip to content

docs(skills): add practical examples and verification patterns (batch 1)#374

Merged
martincjarvis merged 10 commits intomainfrom
feat/skill-follow-up-enhancements
Jan 16, 2026
Merged

docs(skills): add practical examples and verification patterns (batch 1)#374
martincjarvis merged 10 commits intomainfrom
feat/skill-follow-up-enhancements

Conversation

@martincjarvis
Copy link
Collaborator

@martincjarvis martincjarvis commented Jan 16, 2026

Summary

  • Add practical examples, templates, and verification commands to 12 skills
  • Enhance documentation based on skills review findings

Skills Enhanced

Issue Skill Enhancement
#314 contract-consistency-validation OpenAPI/schema test examples, non-HTTP contracts checklist
#317 documentation-as-code Verification commands, evidence capture patterns
#318 dotnet-bespoke-code-minimisation PR review checklist, OSS vs bespoke comparison
#320 dotnet-domain-primitives API boundary before/after example, validation steps
#321 dotnet-efcore-practices Coverlet config, xUnit test examples, verification
#322 dotnet-healthchecks Endpoint verification, readiness/liveness guidelines
#323 dotnet-logging-serilog Fail-fast startup test pattern
#324 dotnet-mapping-standard Unit test template, DI gating checklist
#326 dotnet-source-generation-first Benchmark template, acceptable exceptions
#329 finishing-a-development-branch Decision flowchart, MVP verification path
#341 persona-switching Validation commands, rollback procedure
#357 walking-skeleton-delivery Skeleton acceptance test, pipeline example

Remaining Work

27 skill follow-up issues remain open for future enhancement.

Test plan

Closes #314, #317, #318, #320, #321, #322, #323, #324, #326, #329, #341, #357


Generated with Claude Code

mcj-coder and others added 10 commits January 15, 2026 17:13
…net-efcore-practices

- Add Coverlet configuration examples (.runsettings and .csproj patterns)
- Add xUnit repository pattern examples with async test setup
- Add verification commands (dotnet test with /p:CollectCoverage flag)
- Add verification checklist for migrations exclusion and test patterns
- Update cspell dictionary with 'opencover' term

Refs: #321
Refs: #317

Add sample verification commands and evidence capture patterns:
- Local verification commands (npm run lint:md, npm run spell)
- Specific file validation examples
- Evidence capture patterns for issue comments
- Brownfield baseline verification commands
- Clarification that doc-only verification is process-only (analytical)
Refs: #317

Add sample verification commands and evidence capture patterns:
- Local verification commands (npm run lint:md, npm run spell)
- Specific file validation examples
- Evidence capture patterns for issue comments
- Brownfield baseline verification commands
- Clarification that doc-only verification is process-only (analytical)
…on section

Add new 'API Boundary Mapping & Validation' section with:
- Before example showing primitive obsession at API boundaries
- After example showing domain primitives with explicit mapping
- Validation checklist for controllers, service layer, mapping, and tests

Demonstrates practical transformation from primitives to domain types at layer
boundaries with clear responsibility separation. Refs: #320
…poke-code-minimisation

Add two new sections to enhance the skill per issue #318:
- PR review checklist: actionable items for reviewing bespoke code proposals
- Worked example: concrete comparison of custom mapper vs AutoMapper vs Mapperly
  with decision framework and verification criteria

Refs: #318
Add explicit contract test examples and minimal checklist for non-HTTP contracts
to the contract-consistency-validation skill reference:

- OpenAPI specification example with breaking change detection
- JSON Schema validation example with AJV code
- gRPC contract checklist with field numbering guidance
- Message queue/event contract checklist
- Database/storage contract checklist
- Command-line tool reference for each contract type

Also add 'avsc' (Avro schema format) to CSpell dictionary.

Addresses acceptance criteria for issue #314.

Refs: #314
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…cements

- dotnet-healthchecks: Add endpoint verification and readiness/liveness guidelines (#322)
- dotnet-logging-serilog: Add fail-fast startup test pattern (#323)
- dotnet-source-generation-first: Add benchmark template and exceptions (#326)
- cspell: Add 'Diagnoser' to dictionary

Refs: #322, #323, #326
…g-skeleton

- dotnet-mapping-standard: Add unit test template and DI gating checklist (#324)
- finishing-a-development-branch: Add decision flowchart and MVP verification (#329)
- persona-switching: Add validation commands and rollback procedure (#341)
- walking-skeleton-delivery: Add skeleton acceptance test and pipeline example (#357)
- cspell: Add 'clearsign' to dictionary

Refs: #324, #329, #341, #357
@martincjarvis martincjarvis enabled auto-merge (squash) January 16, 2026 09:09
Copy link
Owner

@mcj-coder mcj-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. 12 skill enhancements with practical examples, templates, and verification patterns. Good batch of improvements.

@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Warnings
⚠️

[Issue] 1 checked acceptance criteria may be missing evidence links. Recommended format: - [x] Item (evidence)

⚠️

[Issue] No plan comment found on linked issue. Post a plan comment with "## Plan" header or link to docs/plans/ before implementation. See Issue #177 for exemplar.

Messages
📖 All PR validation checks passed.

Generated by 🚫 dangerJS against 791c1bc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill follow-up: contract-consistency-validation

2 participants