Skip to content

docs(skills): add Overview and Red Flags sections (Phase 3)#384

Merged
martincjarvis merged 1 commit intomainfrom
docs/phase3-structural-fixes
Jan 16, 2026
Merged

docs(skills): add Overview and Red Flags sections (Phase 3)#384
martincjarvis merged 1 commit intomainfrom
docs/phase3-structural-fixes

Conversation

@mcj-coder
Copy link
Owner

@mcj-coder mcj-coder commented Jan 16, 2026

Summary

  • Add standardized Overview sections to 16 skills that were missing them
  • Add Red Flags - STOP sections with "Thought | Reality" tables to 21 skills
  • Follows patterns from exemplar skills (issue-driven-delivery, skills-first-workflow)

Skills Updated

Added both Overview and Red Flags:

  • dotnet-best-practices
  • csharp-best-practices
  • dotnet-bespoke-code-minimisation
  • dotnet-domain-primitives
  • dotnet-efcore-practices
  • dotnet-mapping-standard
  • dotnet-specification-pattern
  • dotnet-testing-assertions
  • dotnet-healthchecks
  • dotnet-source-generation-first
  • dotnet-open-source-first-governance
  • innersource-governance-bootstrap
  • observability-logging-baseline
  • testing-strategy-dotnet

Added Overview only (already had Red Flags):

  • component-boundary-ownership

Added Red Flags only (already had Overview):

  • monorepo-orchestration-setup
  • pair-programming
  • safe-brownfield-refactor
  • repo-best-practices-bootstrap
  • security-processes
  • testing-strategy-agnostic

Issues

Test Plan

Verification

All 21 modified skill files pass lint checks.

Auto-merge

  • Enable auto-merge after required approvals and checks pass

🤖 Generated with Claude Code

Add standardized Overview sections to skills missing them:
- All .NET skills (dotnet-*, csharp-*)
- component-boundary-ownership
- innersource-governance-bootstrap
- observability-logging-baseline
- testing-strategy-dotnet

Add Red Flags - STOP sections with "Thought | Reality" tables:
- All .NET skills
- monorepo-orchestration-setup
- pair-programming
- safe-brownfield-refactor
- repo-best-practices-bootstrap
- security-processes
- testing-strategy-agnostic
- innersource-governance-bootstrap
- observability-logging-baseline
- testing-strategy-dotnet

This addresses 21 skills total, ensuring consistent structure
following the patterns from exemplar skills (issue-driven-delivery,
skills-first-workflow).

Refs: #383

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Warnings
⚠️

[Issue] 1 checked acceptance criteria may be missing evidence links. Recommended format: - [x] Item (evidence)

⚠️

[Issue] Plan found but no approval comment detected. Add approval comment (e.g., "Approval acknowledged" or "Plan approved") before implementation.

Messages
📖 All PR validation checks passed.

Generated by 🚫 dangerJS against ae89bda

@mcj-coder mcj-coder mentioned this pull request Jan 16, 2026
6 tasks
Copy link
Collaborator

@martincjarvis martincjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All 21 skills updated with consistent Overview and Red Flags sections following established patterns. All CI checks pass.

@martincjarvis martincjarvis merged commit 6f1ada5 into main Jan 16, 2026
12 of 14 checks passed
@martincjarvis martincjarvis deleted the docs/phase3-structural-fixes branch January 16, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Phase 3 - Structural Fixes

2 participants