Skip to content

feat: Add skill structure validation script and CI job#389

Merged
martincjarvis merged 9 commits intomainfrom
feat/skill-structure-validation
Jan 17, 2026
Merged

feat: Add skill structure validation script and CI job#389
martincjarvis merged 9 commits intomainfrom
feat/skill-structure-validation

Conversation

@mcj-coder
Copy link
Owner

@mcj-coder mcj-coder commented Jan 16, 2026

Summary

Implements the structure validation automation recommended in the retrospective.

  • Adds scripts/validate-skill-structure.cjs to validate skill structure
  • Validates: SKILL.md exists, test file exists, frontmatter fields, required sections
  • Adds npm run validate:skills script
  • Adds CI job to enforce validation on PRs

What the validation checks

  1. Required files: SKILL.md, *.test.md, references/README.md (if references/ exists)
  2. Frontmatter: name and description fields, name matches directory
  3. Required sections: ## Overview, ## When to Use, ## Core Workflow

Current state

The validation finds 45 compliance issues across 28 skills that don't have the required sections. This is expected - the validation is working correctly and identifies skills that don't follow SKILL-FORMAT.md.

The CI job is marked as continue-on-error: true temporarily so PRs can still merge. A follow-up issue should be created to update the non-compliant skills.

Issues

Test Plan

  • npm run validate:skills runs and validates all 55 skills (evidence)
  • npm run lint passes (evidence)
  • CI job added and configured (evidence)

Verification

mcj-coder and others added 8 commits January 16, 2026 16:36
Refs: #388

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Validates SKILL.md, *.test.md, and references/README.md existence.

Refs: #388

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Validates name and description fields, ensures name matches directory.

Refs: #388
Validates Overview, When to Use, and Core Workflow sections exist.
Note: Some skills don't currently meet this standard.

Refs: #388
Validates all skills have required files, frontmatter, and sections.

Refs: #388

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Until existing skills are updated to comply with SKILL-FORMAT.md,
the validation job should not block PRs.

Refs: #388
@github-actions
Copy link

github-actions bot commented Jan 16, 2026

Messages
📖 All PR validation checks passed.

Generated by 🚫 dangerJS against e188664

Copy link
Collaborator

@martincjarvis martincjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Validation script correctly identifies non-compliant skills. CI job is appropriately non-blocking until skills are updated.

@martincjarvis martincjarvis merged commit 44e4bd6 into main Jan 17, 2026
6 of 7 checks passed
@martincjarvis martincjarvis deleted the feat/skill-structure-validation branch January 17, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add skill structure validation script and CI job

2 participants