[CC generated] Add unit tests for page build method#1567
Draft
maxschulz-COL wants to merge 1 commit intomainfrom
Draft
[CC generated] Add unit tests for page build method#1567maxschulz-COL wants to merge 1 commit intomainfrom
maxschulz-COL wants to merge 1 commit intomainfrom
Conversation
Add comprehensive unit tests for the Page.build method covering: - Return type verification (html.Div with two children) - Control panel structure and visibility logic - Page components container structure - Verification of essential components (Store, Download, Location, NotificationContainer) - Multiple components and custom layout configurations This removes the TODO comments that were requesting these tests. https://claude.ai/code/session_01UPzkjMSjupFnrZJz9tA4sA
Contributor
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2026-02-03 15:19:42 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds comprehensive unit tests for the
Page.build()method and its related functionality in the vizro-core package. The tests cover:These tests replace the TODO comments that were previously in the test file and provide full coverage of the page build method's behavior, ensuring the correct HTML structure is generated and all required Dash components are properly included.
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
https://claude.ai/code/session_01UPzkjMSjupFnrZJz9tA4sA