Skip to content

[WIP] [Feat] Conditional Notifications#1574

Draft
petar-qb wants to merge 1 commit intomainfrom
feat/conditional_notifications
Draft

[WIP] [Feat] Conditional Notifications#1574
petar-qb wants to merge 1 commit intomainfrom
feat/conditional_notifications

Conversation

@petar-qb
Copy link
Contributor

@petar-qb petar-qb commented Feb 5, 2026

Description

Screenshot

TODO

  • - Refactor _action.py and the way how action notification is extracted and calculated.
  • - Pass through todos and done or open question.
    If we enable text -> va.show_notification(...) conversion, this would look like: notifications={"progress": "Exporting data...", "success": "Data exported successfully!", "error": "Export failed!",},
  • - See ticket issue and cover other edge cases if any.
  • - Check other actions like filter/parameter. What happens if they fail.
    One pros of introducing update_figures is that we don't have to copy-paste similar code for many actions.
  • - Check what happens with the actions chain when no_update, PreventUpdate, or Exception is raised.
  • - add a page that tests an action with different output type [None, data, [data], {"output_id": data}] Make sure that all the combinations are covered.
  • - fix lint and failing unit tests
  • - see schema
  • - write docs
  • - write changelog

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@petar-qb petar-qb self-assigned this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant