Adds reverse tabIndex direction when using shift-tab#105
Open
luke-ransfield wants to merge 1 commit intomcneel:8from
Open
Adds reverse tabIndex direction when using shift-tab#105luke-ransfield wants to merge 1 commit intomcneel:8from
luke-ransfield wants to merge 1 commit intomcneel:8from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for fun, I saw it and thought I'd it implement it.
Changes:
OnKeyDowninstead ofOnKeyPressso can usee.KeyCode == Keys.Tabande.Shift(can revert to using e.KeyChar if that's preferred).NextControlas base forPreviousControlPreviousControlreturns previous control by iterating through controls, storing reference to control inpreviousKey, until it breaks at current controlTo test:
SampleCsModelessTabFormcommand, check that tab press increments tab index, check that tab-shift reverses tab index directionTried to keep consistent code style with existing. Also not sure what your contributions policy is (no worries if you don't accept PRs!)