Skip to content

Conversation

mcous
Copy link
Owner

@mcous mcous commented Jun 7, 2025

Closes #257

After attempting to scope MissingSpecAttributeWarning down to just method calls, I've decided that the point of the warning is fundamentally incompatible with how Decoy currently exists. Decoy mocks want to be extremely flexible spies, and I don't see a way to push attribute validation into that model in a way that won't produce false warnings. A static type-checker is a better tool for the job

Accordingly, this PR removes MissingSpecAttributeWarning entirely. Given that this feature was always buggy, I've chosen to call this change a "fix" rather than a larger release type. Effectively reverts #218

Copy link

codecov bot commented Jun 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (cb399b7) to head (7096796).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   98.41%   98.41%           
=======================================
  Files          19       19           
  Lines         757      759    +2     
  Branches       93       92    -1     
=======================================
+ Hits          745      747    +2     
  Misses         10       10           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcous mcous merged commit 080e690 into main Jun 9, 2025
22 checks passed
@mcous mcous deleted the fix/remove-missing-spec-attribute-warning branch June 9, 2025 14:28
@mcous mcous mentioned this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore some warnings and/or fix issue with @property
1 participant