fix(warnings): remove faulty MissingSpecAttributeWarning
#263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #257
After attempting to scope
MissingSpecAttributeWarning
down to just method calls, I've decided that the point of the warning is fundamentally incompatible with how Decoy currently exists. Decoy mocks want to be extremely flexible spies, and I don't see a way to push attribute validation into that model in a way that won't produce false warnings. A static type-checker is a better tool for the jobAccordingly, this PR removes
MissingSpecAttributeWarning
entirely. Given that this feature was always buggy, I've chosen to call this change a "fix" rather than a larger release type. Effectively reverts #218