chore(test): add assertj-core dependency to timeless-api #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matheus Cruz <[email protected]>
Owner
Author
|
cc: @matheusandre1 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the assertj-core testing library as a dependency to the timeless-api module and establishes test guidelines in the contributing documentation.
- Adds assertj-core 3.27.6 as a test dependency with proper Maven property configuration
- Reorganizes test dependencies in pom.xml to group them together at the end
- Updates CONTRIBUTING.md with new test guidelines including assertj usage requirement and naming conventions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| timeless-api/pom.xml | Adds assertj-core dependency, reorganizes test dependencies, and includes XML formatting improvements |
| CONTRIBUTING.md | Updates test guidelines to mandate assertj usage and defines test naming conventions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR adds the assertj-core testing library as a dependency to the timeless-api module and establishes test guidelines in the contributing documentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.