-
Notifications
You must be signed in to change notification settings - Fork 9
ci: Generate OCI images for timeless-api and whatsapp apps #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Add the user secrets to the main repository. secrets.QUAY_USERNAME |
mcruzdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matheusandre1 I left a simple comment, I think for whatsapp we can keep as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds OCI image build and publish capabilities for the timeless-api (Java) and whatsapp (Node.js) applications using Cloud Native Buildpacks. The implementation uses Paketo buildpacks to create container images and publishes them to Quay.io registry.
Key changes:
- Integration of Pack CLI and Quay.io registry publishing into the CI pipeline for both applications
- Addition of Aptfile for specifying system dependencies required by the WhatsApp application (Chromium and related libraries)
- Creation of a Dockerfile for the WhatsApp application (though it won't be used with the buildpacks approach)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| .github/workflows/pipeline.yml | Added Pack CLI setup, Quay.io authentication, and image build/publish steps for both timeless-api and whatsapp jobs |
| whatsapp/Dockerfile | Added Dockerfile with Node.js base image and Puppeteer/Chromium dependencies (not used by buildpacks) |
| whatsapp/Aptfile | Added system package dependencies for Chromium browser support required by whatsapp-web.js |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
cc: @mcruzdev , Please advise me on possible pipeline improvements. |
|
I tried following this |
0a0d7ea to
be3e013
Compare
mcruzdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Let's see if it works!
#80