feat(sign-in): add feedback on sign-in page #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
commented
Dec 1, 2025
timeless-api/src/main/webui/src/app/pages/sign/sign-in/sign-in.component.ts
Outdated
Show resolved
Hide resolved
mcruzdev
commented
Dec 1, 2025
timeless-api/src/main/webui/src/app/pages/sign/sign-in/sign-in.component.ts
Outdated
Show resolved
Hide resolved
Owner
Author
|
@matheusandre1 could you take a review? |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Contributor
|
@mcruzdev, Who am I to review something, especially for you... But it turned out well. In the future, with possible expansion, improvements could be made to the componentization, and a specific component could be abstracted for errors. |
Owner
Author
You are human like me haha, I agree with you about a centralized component, I am not an expert with Angular, but I can try to do it |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Owner
Author
|
I created an issue to track it #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #56