-
Notifications
You must be signed in to change notification settings - Fork 9
Feat Add a sign out button #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timeless-api/src/main/webui/src/app/components/logout-button/logout-button.component.html
Outdated
Show resolved
Hide resolved
timeless-api/src/main/webui/src/app/components/logout-button/logout-button.component.html
Outdated
Show resolved
Hide resolved
timeless-api/src/main/webui/src/app/components/logout-button/logout-button.component.scss
Outdated
Show resolved
Hide resolved
mcruzdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @matheusandre1 thanks for this pull request, I loved your pull request but I think we need to change some things.
I think we do not need a component for a simple logout button, creating an exclusive component can be an over-abstraction (we will not use in another place).
In that case we do not need a new component, we can easily use the button component from primeng <p-button>.
Not, we just need to delete the token.
No worry, but let try to use tailwindcss for it. |
|
I'll refactor in the afternoon. |
|
@mcruzdev delete token? |
I just confirmed what you already did. delete the token from local storage. |
|
The next step is part of usability, and defining a color |
f4b0564 to
c03422f
Compare
|
Please, when you add a frontend feature... add a screenshot just to see what is changed/applied; |
mcruzdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! You rock
#77
hm...,
I believe it's good for a start... "the button is working"
Questions to consider and then implement...
1 - Will there be any integration with the back-end for this part?
2 - I put a margin-left: auto, but later the layout can be improved and isolated in a box...