Skip to content

Conversation

@matheusandre1
Copy link
Contributor

#77

hm...,

I believe it's good for a start... "the button is working"

Questions to consider and then implement...

1 - Will there be any integration with the back-end for this part?
2 - I put a margin-left: auto, but later the layout can be improved and isolated in a box...

Copy link
Owner

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matheusandre1 thanks for this pull request, I loved your pull request but I think we need to change some things.

I think we do not need a component for a simple logout button, creating an exclusive component can be an over-abstraction (we will not use in another place).

In that case we do not need a new component, we can easily use the button component from primeng <p-button>.

@mcruzdev
Copy link
Owner

mcruzdev commented Dec 3, 2025

1 - Will there be any integration with the back-end for this part?

Not, we just need to delete the token.

2 - I put a margin-left: auto, but later the layout can be improved and isolated in a box...

No worry, but let try to use tailwindcss for it.

@matheusandre1
Copy link
Contributor Author

I'll refactor in the afternoon.

@matheusandre1
Copy link
Contributor Author

@mcruzdev delete token?
I didn't understand...

@mcruzdev
Copy link
Owner

mcruzdev commented Dec 3, 2025

@mcruzdev delete token?
I didn't understand...

I just confirmed what you already did. delete the token from local storage.

@matheusandre1
Copy link
Contributor Author

The next step is part of usability, and defining a color

@mcruzdev
Copy link
Owner

mcruzdev commented Dec 3, 2025

Please, when you add a frontend feature... add a screenshot just to see what is changed/applied;

Copy link
Owner

@mcruzdev mcruzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! You rock

@mcruzdev mcruzdev merged commit 6fc9c51 into mcruzdev:main Dec 3, 2025
3 checks passed
@matheusandre1 matheusandre1 deleted the feat-issue77 branch January 5, 2026 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants