Skip to content

zephyr: refactor zephyr port #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

zephyr: refactor zephyr port #1411

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
289eccf
boot: zephyr: Add Zephyr manifest file (west.yml)
legrand-gregshue Jul 8, 2022
a215bbc
boot: zephyr: module Kconfig beneath zephyr/
legrand-gregshue Jul 8, 2022
765ca5c
boot: zephyr: Force module name to `mcuboot`
legrand-gregshue Jul 8, 2022
79cebf4
boot: zephyr: boot/zephyr/include/ to zephyr/include/
legrand-gregshue Jul 8, 2022
3ad1049
boot: zephyr: boot/zephyr/CMakeLists.txt under zephyr/subsys/
legrand-gregshue Jul 8, 2022
ac37fb2
boot: zephyr: Move zephyr sources to `zephyr/subsys/mcuboot_svc`
legrand-gregshue Jul 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions west.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Copyright (c) 2022 Legrand North America, LLC.
Copy link
Collaborator

@nvlsianpu nvlsianpu Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is done?
In zephyr project the MCUboot is just one of submodule. So zephyr-rtos manifest points given MCUboot version.

Copy link
Author

@gregshue gregshue Oct 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to resolve MCUBoot issue #1410.

The problem is the Zephyr port of MCUBoot does not allow me to configure and build an MCUBoot image from my proprietary workspace application module. This is different behavior from most(?) other Zephyr (sub)modules and prevents me from keeping all of my project configurations and builds in one repository. This refactoring aligns the Zephyr port with the Zephyr configuration and build system modularity and enables standard Zephyr module behavior.

Copy link
Contributor

@tejlmand tejlmand Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to resolve MCUBoot issue #1410.

The problem is the Zephyr port of MCUBoot does not allow me to configure and build an MCUBoot image from my proprietary workspace application module. This is different behavior from most(?) other Zephyr (sub)modules and prevents me from keeping all of my project configurations and builds in one repository.

I believe this is solved by zephyrproject-rtos/zephyr#51166

Copy link
Author

@gregshue gregshue Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tejlmand I tried your suggestion but it does not solve my scenario. It missed picking up boards/ configs within APPLICATION_CONFIG_DIR.

#
# SPDX-License-Identifier: Apache-2.0

# The west manifest file for Zephyr ecosystem development.
#
# Usage:
# west init -m https://github.com/mcu-tools/mcuboot
# west update

manifest:
version: "0.12"

remotes:
- name: zephyrproject
url-base: https://github.com/zephyrproject-rtos
- name: mcu-tools
url-base: https://github.com/mcu-tools

defaults:
remote: mcu-tools

projects:
- name: zephyr
revision: main
remote: zephyrproject
import:
name-blocklist:
- mcuboot

self:
path: mcuboot