fixed duplicate NDCs, updated script to hopefully prevent them in the…#104
Merged
fixed duplicate NDCs, updated script to hopefully prevent them in the…#104
Conversation
… future. Still need to add command to delete NDCs from ndc_clinical_drug that get inserted into ndc_branded_drug. Addresses #103
Added comments to clarify the purpose of SQL operations related to NDC and branded drugs.
hoganwr
commented
Jan 4, 2026
Collaborator
Author
hoganwr
left a comment
hoganwr
left a comment
There was a problem hiding this comment.
Did build on second machine. Got same results. Resolves numerous duplicate NDCs. Only thing left is to test the new script on next RxNorm build (tentatively Jan 6 2026).
…un that update as a separate PR, so only checking in the correct script for doing the update in this PR.
Collaborator
Author
|
Status update: need to check the updated script update-dron-from-rxnorm.sql on a separate machine, and once verified that it works, can merge this PR (and then do Jan 2026 RxNorm update as next but separate PR) |
…NDCs. Don't expect a recurrence.
Collaborator
Author
|
Ok this checks out on both machines, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… future. Still need to add command to delete NDCs from ndc_clinical_drug that get inserted into ndc_branded_drug. Addresses #103