Added support for the non US Dexcom Share server#68
Open
Adirael wants to merge 1 commit intomddub:masterfrom
Open
Added support for the non US Dexcom Share server#68Adirael wants to merge 1 commit intomddub:masterfrom
Adirael wants to merge 1 commit intomddub:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non US Dexcom Share servers use a different server endpoint. I added a checkbox on the configuration and modified the data retriever to allow users to select which server should the data come from.
I made the changes in a bit of a rush but they're relatively minimal. I'm a new user but I'm pretty sure everything's working correctly.