Webservice: List issued certificates

[michallohnisky]

Resolves #419 .

Use-case example:
An external application (CRM) periodically downloads new certificates and associates them with users using their email addresses. The timecreatedfrom filter is used to download certificates issued after the last synchronization.

[mdjnelson]

Hi,

There are a few things that need addressed.

1. The complaints from the GitHub Actions report.
2. I support Moodle 4.1 upwards so we should be using type hints, return types etc.
3. This does not resolve Call list of certificates for a user via API #419 as that specifies getting certificates for a user, not from a date.
4. Indentation of SQL should be as https://moodledev.io/general/development/policies/codingstyle/sql.
5. There are no checks to see if the user can actually get the list of certificates meaning anyone can get a list of certificates which is a huge security issue.

Please address these and I will take another look.

[michallohnisky]

Hi, thanks. I will try my best :-) .

1. Almost done. They disappeared after my push. Can you run them again?
2. Can you give me an example? Because for example \mod_customcert\external::list_issues_parameters has a return type in annotations, so it is the same as \mod_customcert\external::delete_issue_parameters
3. Done. I added additional filters.
4. I cannot see what is wrong, can you give me an example?
5. Done. I added mod/customcert:viewallcertificates

[michallohnisky]

1. Done.

[mdjnelson]

Thanks @michallohnisky. Are you able to add some unit tests to this as well? Take a look at https://github.com/mdjnelson/moodle-mod_customcert/blob/MOODLE_404_STABLE/tests/external_test.php to see other examples. :)

[mdjnelson]

Regarding the points -

2. These web services were created ages ago before type hinting and return types were a thing in PHP.
3. The SQL indentation was corrected so it's fine now.

Cheers.

P.S Once all done please squash into one commit.

[michallohnisky]

Are you able to grant me permission to run the checks? If I am able to run them immediately after every push, I think I can add some unit tests as well.

[mdjnelson]

You can run the unit tests locally before pushing them. :) https://docs.moodle.org/dev/Writing_PHPUnit_tests

[michallohnisky]

I understand :-) , but I would need to set up the whole development stage and Docker containers, and it would take a lot of time for a single unit test.

I squashed the commits.

[mdjnelson]

I run the unit tests on my machine and I do not use Docker for Moodle development as I find the Moodle HQ container to be extremely slow. So, its possible to do this without Docker.

[indicozy]

I'm having issue with this feature because it doesn't work if I use user's token in wstoken. However if I use webservice's token it's working fine

[indicozy]

Additionally, API doesn't return courses of certificates

[mdjnelson]

I don't think adding from is necessary as it is implied with timecreated. Prefer to keep this consistent throughout the codebase and just stick with timecreated. TIA.