Skip to content

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Apr 18, 2024

Discovered by the @openwebdocs BCD collector thanks to openwebdocs/mdn-bcd-collector#1341.
No spec_url yet, see whatwg/websockets#48

Adding the "websocket-stream" tag, sounds good Philip?

@Elchi3 Elchi3 requested a review from foolip April 18, 2024 14:46
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Apr 18, 2024
@foolip
Copy link
Contributor

foolip commented Apr 18, 2024

Adding the "websocket-stream" tag, sounds good Philip?

This is an interesting case. Because of https://caniuse.com/websockets and https://websockets.spec.whatwg.org/ I would say that "websockets" is the best name for the base feature which goes back ages. But if we follow the style of turning CoolThing APIs into "cool-thing" identifiers, this should be "web-socket-stream". That looks weird alongside "websockets", but maybe that's OK.

We can always rename it later, but for now I guess I'd go with "web-socket-stream" based on the WebSocketStream API name. It helps that this is distinct from the old WebSocket interface, and not a stream property or something on WebSocket.

@Elchi3
Copy link
Member Author

Elchi3 commented Apr 22, 2024

Thanks @foolip, I have no strong feelings about the id and accepted your suggestion. Merging this.

Do you want me to open a PR on web-features or do we have tooling in place that will signal to web-features that we have a new tag in BCD which will spawn something (automatically) over there?

@Elchi3 Elchi3 merged commit dd678d2 into mdn:main Apr 22, 2024
@Elchi3 Elchi3 deleted the websocket-stream branch April 22, 2024 07:58
@foolip
Copy link
Contributor

foolip commented Apr 22, 2024

@Elchi3 we don't have any tooling for this, but that would make a lot of sense. We could have a test that fails if there are any features in BCD that aren't in web-features, and a list for allowed exceptions which we could treat like a burndown list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants