-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat(browsers): add Bun to BCD #23440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is there anything needed to push this along/fill out more data? happy to pitch in if it'd help |
This is just a proof of concept right now, and is awaiting owner consensus to add! |
This pull request has merge conflicts that must be resolved before it can be merged. |
Since Bun is currently covered by runtime-compat, I would suggest closing this PR for now. |
NodeJS and Deno are also covered by runtime-compat, but we include data for both of them in BCD. I think that it's helpful to include Bun's data in BCD especially as there's been lots of consumer interest, and runtime-compat only obtains the data for the latest versions of each runtime. I would like to keep this PR open as a draft as a reminder to come to a decision. |
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
@caugner bumping this, we would really love it if your team added support! |
I've opened #27599 for automating the release data for all JavaScript runtimes! Regarding documentation about updating Bun data, we don't really have that for any runtime that we track in BCD? I do think that's a good idea since we talk about using the mdn-bcd-collector for browsers, but we don't really talk about using runtime-compat for Node.js and Deno yet, and we should probably hold off on documenting it until RCD has been updated to run on all runtime versions, not just the latest! |
Thanks!
Could be that we don't have that for deno and node but the guidelines have become stricter (see #27213). The goal here is to not add new runtimes/browsers to BCD anymore that outdate quickly. We still need to fix that for node and deno but for new additions (bun), it makes sense to have a plan from the start. |
I have just opened an OWD project proposal regarding this, to establish a proper plan for not only automatically testing Bun, but Node.js and Deno as well (since I think that a plan for one is a plan for all): openwebdocs/project#229 |
As we discussed in our weekly meeting, I have pulled the changes from #27625 into this PR, so that everything is added all in one go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (ran npm run diff:flat
on this branch), just one nit.
Thank you everyone! 🎉 |
This PR adds the Bun runtime to BCD and tracks the data.
The initial data was generated with the help of the runtime-compat project, a project that uses the mdn-bcd-collector to collect test results for JavaScript runtimes.
The release data was obtained by a script written by @alii, which has been integrated into the release updater workflow.
Special thanks to the Bun team for all of their assistance!
Fixes #18484.
Closes #27625.