Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/PerformanceNavigationTiming.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"activationStart": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/PerformanceNavigationTiming/activationStart",
"spec_url": "https://wicg.github.io/nav-speculation/prerendering.html#performance-navigation-timing-extension",
"tags": [
"web-features:speculation-rules"
],
Expand Down
3 changes: 2 additions & 1 deletion api/Request.json
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,8 @@
"__compat": {
"description": "`speculationrules` value",
"tags": [
"web-features:fetch"
"web-features:fetch",
"web-features:speculation-rules"
],
"support": {
"chrome": {
Expand Down
14 changes: 14 additions & 0 deletions html/elements/script.json
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,7 @@
"__compat": {
"description": "`eagerness` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#eagerness",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#speculation-rule-eagerness",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -802,6 +803,7 @@
"__compat": {
"description": "`expects_no_vary_search` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#expects_no_vary_search",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all these keys pointing to https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule, it would be preferable to add a text fragment, as this would allow us (in the future) to detect when a feature like this disappears from the spec.

But this is not a strict requirement for now, so we can merge as is.

/cc @Elchi3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess as long as it’s a fragment after the id I’m ok with that. Worse case it still links to the anchor o was linking to anyway. Let me add those back then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be preferable to add a text fragment

fwiw, I prefer real ids/anchors/definitions present in the specs. Text fragments are very unstable and I currently have no implementation for validating them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I was actually suggesting text fragments combined with ID fragments:

https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule:~:text=%2C%20%22tag%22%2C

For validation, you could just ignore the :~: part for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated now so think this is good to merge.

"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -845,6 +847,7 @@
"__compat": {
"description": "`prefetch` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#prefetch",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#speculation-rule-set-authoring-requirements",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -926,6 +929,7 @@
"__compat": {
"description": "`referrer_policy` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#referrer_policy",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -961,6 +965,7 @@
"__compat": {
"description": "`relative_to` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#relative_to_2",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -996,6 +1001,7 @@
"__compat": {
"description": "`requires` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#requires",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#speculation-rule-requirement",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1032,6 +1038,7 @@
"__compat": {
"description": "`anonymous-client-ip-when-cross-origin` value",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#anonymous-client-ip-when-cross-origin",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#speculation-rule-requirement",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1078,6 +1085,7 @@
"__compat": {
"description": "`source` key is optional",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#source",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1113,6 +1121,7 @@
"__compat": {
"description": "`tag` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#tag",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#speculation-rule-tag",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1148,6 +1157,7 @@
"__compat": {
"description": "`target_hint` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#target_hint",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1184,6 +1194,8 @@
"urls": {
"__compat": {
"description": "`urls` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#urls",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-speculation-rule",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -1220,6 +1232,8 @@
"where": {
"__compat": {
"description": "`where` key",
"mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Reference/Elements/script/type/speculationrules#where",
"spec_url": "https://html.spec.whatwg.org/multipage/speculative-loading.html#valid-document-rule-predicate",
"tags": [
"web-features:speculation-rules"
],
Expand Down
2 changes: 2 additions & 0 deletions http/headers/Supports-Loading-Mode.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
"credentialed-prerender": {
"__compat": {
"description": "`credentialed-prerender` directive",
"spec_url": "https://wicg.github.io/nav-speculation/prerendering.html#supports-loading-mode-credentialed-prerender",
"tags": [
"web-features:speculation-rules"
],
Expand Down Expand Up @@ -72,6 +73,7 @@
"fenced-frame": {
"__compat": {
"description": "`fenced-frame` directive",
"spec_url": "https://wicg.github.io/fenced-frame/#supports-loading-mode",
"tags": [
"web-features:speculation-rules"
],
Expand Down