-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Chrome 110 applies User-Agent reduction to Navigator properties + User-Agent header
#28275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
5b65fc0
2f6fcf2
d611bfe
e594f1c
6bcd3c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -324,6 +324,42 @@ | |
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| }, | ||
| "User-Agent_reduction": { | ||
| "__compat": { | ||
| "description": "Provides limited information due to [User-agent](https://developer.mozilla.org/docs/Web/HTTP/Guides/User-agent_reduction) reduction.", | ||
| "spec_url": "https://compat.spec.whatwg.org/#ua-string-section", | ||
|
Comment on lines
+328
to
+331
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Elchi3 What do you think about this behavioral subfeature?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You didn't ask me so FWIW, I'm -1 on this as a feature or at least one that is
If it's descriptive, then it's merely documentation that does not specify anything. The spec doesn't actually say what the vendors must or should do, just what they have done as convention. I think this is comparable to linking to an MDN page in a I think this would be better as a note that says exactly what's being reduced. Something along the lines of:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Your logic here sounds reasonable, but downgrading this to a note troubles me a bit. I am documenting user-agent reduction and what it means to the values reported by the I worry that if it is just a note, it'll be fairly easy to miss the note.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I acknowledge this concern and I agree that is a bit obscure in a note. That said, maybe a change to the docs might help? My suggestion for the docs would be to be somewhat more aggressive in saying that the content of a UA string is not actually standardized (even if the string's format is) and, theoretically, could change at any time. The browser tables might tell you how and when UA strings have changed, but I would hate to suggest to a developer that they could or should rely on that information.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair point. Could we do both? I'd still like UA reduction to be called out in the compat tables (and let's face it, we'll need to add another data point if a browser decides to do a U-turn, whether the info is contained in notes or separate data points). But I also see the value in updating the doc that the data point links to, to make it clearer that the UA string content is still not standardized.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If that means we can put It would still be good to update the docs, as previously discussed.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I did not think editing the spec would be an option. That would be ideal!
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, so if @miketaylr can make that change to the spec, I don't think there is anything more for me to do here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The relevant issue to follow is whatwg/compat#272 - I will be at TPAC next week and will aim to make edits to resolve. Feel free to merge this on faith, or wait. :)
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If possible, it would be nice if the spec update could explicitly introduce the term "User-Agent reduction" with a specific identifier to which BCD could link instead of the more general The User-Agent String section. |
||
| "support": { | ||
| "chrome": { | ||
| "version_added": "110" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "113" | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": false | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": { | ||
| "version_added": false | ||
| }, | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "audioSession": { | ||
|
|
@@ -2970,6 +3006,42 @@ | |
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| }, | ||
| "User-Agent_reduction": { | ||
| "__compat": { | ||
| "description": "Provides limited/generic information due to [User-agent](https://developer.mozilla.org/docs/Web/HTTP/Guides/User-agent_reduction) reduction.", | ||
| "spec_url": "https://compat.spec.whatwg.org/#ua-string-section", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "110" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "113" | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": false | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": { | ||
| "version_added": false | ||
| }, | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "plugins": { | ||
|
|
@@ -5487,6 +5559,42 @@ | |
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| }, | ||
| "User-Agent_reduction": { | ||
| "__compat": { | ||
| "description": "Provides limited information due to [User-agent](https://developer.mozilla.org/docs/Web/HTTP/Guides/User-agent_reduction) reduction.", | ||
| "spec_url": "https://compat.spec.whatwg.org/#ua-string-section", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "110" | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "113" | ||
| }, | ||
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": false | ||
| }, | ||
| "firefox_android": "mirror", | ||
| "oculus": "mirror", | ||
| "opera": "mirror", | ||
| "opera_android": "mirror", | ||
| "safari": { | ||
| "version_added": false | ||
| }, | ||
| "safari_ios": "mirror", | ||
| "samsunginternet_android": "mirror", | ||
| "webview_android": { | ||
| "version_added": false | ||
| }, | ||
| "webview_ios": "mirror" | ||
| }, | ||
| "status": { | ||
| "experimental": true, | ||
| "standard_track": true, | ||
| "deprecated": false | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "userAgentData": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's my suggestion, but before applying, I'd like to get a second opinion by @ddbeck, who might have a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this sounds good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The corresponding docs have just been merged, so I'd like to expedite adding this data.
I like your suggestion, so for now I'm going to make this update in the places it appears. If we want to improve it further, I am happy to do so in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This text is fine, but see my other comment on the whole structure of this feature: #28275 (comment)