Skip to content

fix(lint): refine standard-track exception handling#29224

Merged
caugner merged 5 commits intomainfrom
refine-spec-url-lint
Mar 11, 2026
Merged

fix(lint): refine standard-track exception handling#29224
caugner merged 5 commits intomainfrom
refine-spec-url-lint

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Mar 10, 2026

Summary

Fixes two issues noticed after merging #28810:

  1. Stage changes to the exception list when running npm run lint:fix as part of the pre-commit hook. (Otherwise commits that fix spec URLs won't automatically include the update to the exception list.)
  2. Decouple the test case from the exception list. (The unit test started failing both in Add more spec_urls; set some standard_tracks to false (APIs A-E) #27671 and Fix standard track exceptions #29223, because the tested feature is no longer in the list.)

Test results and supporting details

Related issues

@caugner caugner requested a review from a team as a code owner March 10, 2026 17:18
@caugner caugner requested a review from LeoMcA March 10, 2026 17:18
@github-actions github-actions bot added infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. size:l [PR only] 101-1000 LoC changed labels Mar 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2026

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one nit:

@caugner caugner enabled auto-merge (squash) March 11, 2026 10:17
@caugner caugner merged commit fda1444 into main Mar 11, 2026
15 checks passed
@caugner caugner deleted the refine-spec-url-lint branch March 11, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infrastructure issues (npm, GitHub Actions, releases) of this project linter Issues or pull requests regarding the tests / linter of the JSON files. size:l [PR only] 101-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants