Skip to content

chore(scripts): refine lint, add fix, drop format#446

Merged
LeoMcA merged 3 commits intomainfrom
refine-lint-scripts
Feb 27, 2026
Merged

chore(scripts): refine lint, add fix, drop format#446
LeoMcA merged 3 commits intomainfrom
refine-lint-scripts

Conversation

@caugner
Copy link
Contributor

@caugner caugner commented Feb 19, 2026

Description

Refines the linting-related scripts:

  • updated lint script to run ESLint and prettier in check mode
  • added fix script to run ESLint and prettier in fix mode
  • removed format script

Motivation

Noticed that some files were unformatted, and this was not caught by npm run lint (which only ran ESLint in fix mode).

Additional details

Related issues and pull requests

Merge #445 first.

@caugner caugner requested review from a team and mdn-bot as code owners February 19, 2026 10:58
@caugner caugner requested a review from LeoMcA February 19, 2026 10:58
@caugner caugner requested review from a team as code owners February 19, 2026 11:03
@caugner caugner requested a review from dipikabh February 19, 2026 11:03
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

Any code referenced in docs should be linted/prettified anyway by the workflows there, so this should make things more consistent. @mdn/content-team any concerns, or shall I merge?

@dipikabh
Copy link

No concerns. Thanks both!

@LeoMcA LeoMcA enabled auto-merge (squash) February 27, 2026 10:12
@LeoMcA
Copy link
Member

LeoMcA commented Feb 27, 2026

@dipikabh I think I need a review approval to have the permissions to merge

Copy link

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right! Here you go. Thanks!

@LeoMcA LeoMcA merged commit c8e2796 into main Feb 27, 2026
6 checks passed
@LeoMcA LeoMcA deleted the refine-lint-scripts branch February 27, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants