Skip to content

Add bank registry support for Moldova#272

Open
Mihaileahu17 wants to merge 3 commits intomdomke:mainfrom
Mihaileahu17:moldova-iban
Open

Add bank registry support for Moldova#272
Mihaileahu17 wants to merge 3 commits intomdomke:mainfrom
Mihaileahu17:moldova-iban

Conversation

@Mihaileahu17
Copy link

Summary

This PR adds bank registry support for Moldova (MD) with 10 commercial banks.

Changes

  • Added schwifty/bank_registry/manual_md.json with Moldova bank data
  • Enabled existing Moldova IBAN validation test in tests/test_iban.py
  • Updated CHANGELOG.rst

Testing

  • All existing tests pass (376 tests)
  • Moldova IBAN validation works correctly
  • Bank lookup from IBAN returns correct information

Banks included

  • MAIB (Moldova Agroindbank) - AG / AGRNMD2X
  • Moldindconbank - ML / MOLDMD2X
  • Victoriabank - VI / VICBMD2X
  • OTP Bank - MO / MOBBMD22
  • ProCredit Bank - PR / PRCBMD22
  • Energbank - EN / ENEGMD22
  • FinComBank - FT / FTMDMD2X
  • EXIMBANK - EX / EXMMMD22
  • EuroCreditBank - EC / ECBMMD2X
  • Comerţbank - CB / CMTBMD2X

Example usage

from schwifty import IBAN

iban = IBAN("MD24AG000225100013104168")
print(iban.bank_code)        # 'AG'
print(iban.bank['name'])     # "Banca Comercială 'Moldova Agroindbank' S.A."
print(iban.bank['bic'])      # 'AGRNMD2X'
print(iban.formatted)        # 'MD24 AG00 0225 1000 1310 4168'

Copilot AI review requested due to automatic review settings February 19, 2026 12:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/extends Moldova (MD) bank registry data to enable IBAN → BIC/bank lookups and documents the change in the changelog.

Changes:

  • Added a Moldova manual bank registry JSON with 10 commercial banks.
  • Re-enabled the Moldova IBAN→BIC validation case in the IBAN tests.
  • Added an “Unreleased” changelog entry describing the Moldova registry update.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/test_iban.py Re-enables MD IBAN → BIC test vector.
schwifty/bank_registry/manual_md.json Introduces Moldova commercial bank entries for bank-code/BIC/name mapping.
CHANGELOG.rst Documents the Moldova registry addition under “Unreleased”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants