Add bank registry support for Moldova#272
Open
Mihaileahu17 wants to merge 3 commits intomdomke:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds/extends Moldova (MD) bank registry data to enable IBAN → BIC/bank lookups and documents the change in the changelog.
Changes:
- Added a Moldova manual bank registry JSON with 10 commercial banks.
- Re-enabled the Moldova IBAN→BIC validation case in the IBAN tests.
- Added an “Unreleased” changelog entry describing the Moldova registry update.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
tests/test_iban.py |
Re-enables MD IBAN → BIC test vector. |
schwifty/bank_registry/manual_md.json |
Introduces Moldova commercial bank entries for bank-code/BIC/name mapping. |
CHANGELOG.rst |
Documents the Moldova registry addition under “Unreleased”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds bank registry support for Moldova (MD) with 10 commercial banks.
Changes
schwifty/bank_registry/manual_md.jsonwith Moldova bank datatests/test_iban.pyCHANGELOG.rstTesting
Banks included
Example usage