fix (HelloWorldWidget): adjusted example name to not contain spaces#2
Open
abernh wants to merge 1 commit intomdrideout:mainfrom
Open
Conversation
get_name() is used to generate the widget wrapper class name spaces dont work nicely in CSS class names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_name() is used to generate the widget wrapper class name
and spaces dont work nicely in CSS class names
The originally selected name "Hello World" made me to choose similar names for my widgets with spaces and that caused hours of debugging because the JS was not finding its way to display the controllers.
This "fix" simply adjusts the example widget name to follow a "CSS class name"-compatible pattern