Skip to content

chore(android): use ISO 8601 for session start time attribute #3247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abhaysood merged 1 commit into from
Mar 2, 2026
Merged

chore(android): use ISO 8601 for session start time attribute #3247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/measure/src/main/java/sh/measure/android/MeasureInternal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ internal class MeasureInternal(private val measure: MeasureInitializer) : AppLif
// is triggered.
measure.signalProcessor.track(
SessionStartData,
timestamp = measure.timeProvider.now(),
timestamp = measure.sessionManager.getSessionStartTime(),
type = EventType.SESSION_START,
sessionId = sessionId,
// always sample session start event
Expand Down
6 changes: 5 additions & 1 deletion android/measure/src/main/java/sh/measure/android/attributes/SessionAttributeProcessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package sh.measure.android.attributes

import sh.measure.android.SessionManager
import sh.measure.android.utils.iso8601Timestamp

/**
* Generates the session start time attribute. This attribute changes when a new session is created,
Expand All @@ -10,6 +11,9 @@ internal class SessionAttributeProcessor(
private val sessionManager: SessionManager,
) : AttributeProcessor {
override fun appendAttributes(attributes: MutableMap<String, Any?>) {
attributes.put(Attribute.SESSION_START_TIME_KEY, sessionManager.getSessionStartTime())
attributes.put(
Attribute.SESSION_START_TIME_KEY,
sessionManager.getSessionStartTime().iso8601Timestamp(),
)
}
}
Loading