Skip to content

fix(ios): use correct data type for session start time attribute #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adwinross merged 1 commit into from
Mar 4, 2026
Merged

fix(ios): use correct data type for session start time attribute #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ios/Sources/MeasureSDK/Swift/Attribute/Attribute.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class Attributes: Codable {
var deviceThermalThrottlingEnabled: Bool?
var deviceLowPowerMode: Bool?
var osPageSize: UInt8?
var sessionStartTime: Number?
var sessionStartTime: String?

enum CodingKeys: String, CodingKey {
case threadName = "thread_name"
Expand Down Expand Up @@ -120,7 +120,7 @@ class Attributes: Codable {
deviceThermalThrottlingEnabled: Bool? = nil,
deviceLowPowerMode: Bool? = nil,
osPageSize: UInt8? = nil,
sessionStartTime: Number? = nil) {
sessionStartTime: String? = nil) {
self.threadName = threadName
self.deviceName = deviceName
self.deviceModel = deviceModel
Expand Down Expand Up @@ -181,6 +181,6 @@ class Attributes: Codable {
self.deviceThermalThrottlingEnabled = dict["device_thermal_throttling_enabled"] as? Bool
self.deviceLowPowerMode = dict["device_low_power_mode"] as? Bool
self.osPageSize = dict["os_page_size"] as? UInt8
self.sessionStartTime = dict["session_start_time"] as? Number
self.sessionStartTime = dict["session_start_time"] as? String
}
}
8 changes: 6 additions & 2 deletions ios/Sources/MeasureSDK/Swift/Attribute/SessionAttributeProcessor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,16 @@ import Foundation

final class SessionAttributeProcessor: AttributeProcessor {
private let sessionManager: SessionManager
private let timeProvider: TimeProvider

init(sessionManager: SessionManager) {
init(sessionManager: SessionManager, timeProvider: TimeProvider) {
self.sessionManager = sessionManager
self.timeProvider = timeProvider
}

func appendAttributes(_ attribute: Attributes) {
attribute.sessionStartTime = sessionManager.getSessionStartTime()
if let sessionStartTime = sessionManager.getSessionStartTime() {
attribute.sessionStartTime = timeProvider.iso8601Timestamp(timeInMillis: sessionStartTime)
}
}
}
2 changes: 1 addition & 1 deletion ios/Sources/MeasureSDK/Swift/MeasureInitializer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ final class BaseMeasureInitializer: MeasureInitializer {
self.networkStateAttributeProcessor = NetworkStateAttributeProcessor(measureDispatchQueue: measureDispatchQueue)
self.userAttributeProcessor = UserAttributeProcessor(userDefaultStorage: userDefaultStorage,
measureDispatchQueue: measureDispatchQueue)
self.sessionAttributeProcessor = SessionAttributeProcessor(sessionManager: sessionManager)
self.sessionAttributeProcessor = SessionAttributeProcessor(sessionManager: sessionManager, timeProvider: timeProvider)
self.attributeProcessors = [appAttributeProcessor,
deviceAttributeProcessor,
installationIdAttributeProcessor,
Expand Down
2 changes: 1 addition & 1 deletion ios/Tests/MeasureSDKTests/Mocks/MockMeasureInitializer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ final class MockMeasureInitializer: MeasureInitializer { // swiftlint:disable:th
self.networkStateAttributeProcessor = networkStateAttributeProcessor ?? NetworkStateAttributeProcessor(measureDispatchQueue: self.measureDispatchQueue)
self.userAttributeProcessor = userAttributeProcessor ?? UserAttributeProcessor(userDefaultStorage: self.userDefaultStorage,
measureDispatchQueue: self.measureDispatchQueue)
self.sessionAttributeProcessor = sessionAttributeProcessor ?? SessionAttributeProcessor(sessionManager: self.sessionManager)
self.sessionAttributeProcessor = sessionAttributeProcessor ?? SessionAttributeProcessor(sessionManager: self.sessionManager, timeProvider: self.timeProvider)
self.attributeProcessors = [
self.appAttributeProcessor,
self.deviceAttributeProcessor,
Expand Down