Overlord: Support POP v9 and its finishRockHeaderUpdating command#19
Open
eduard-bagdasaryan wants to merge 7 commits intomasterfrom
Open
Overlord: Support POP v9 and its finishRockHeaderUpdating command#19eduard-bagdasaryan wants to merge 7 commits intomasterfrom
eduard-bagdasaryan wants to merge 7 commits intomasterfrom
Conversation
rousskov
requested changes
Oct 9, 2023
Contributor
Author
eduard-bagdasaryan
left a comment
There was a problem hiding this comment.
Done at 8572e01.
rousskov
requested changes
Oct 19, 2023
src/overlord/Proxy.js
Outdated
|
|
||
| async finishRockHeaderUpdating() { | ||
| const options = { | ||
| 'Overlord-job.type': '\\bRock::HeaderUpdater', |
Contributor
There was a problem hiding this comment.
Alex: I hope \b part of the regex will be relayed correctly,
Eduard: This causes a typeError:
TypeError [ERR_INVALID_CHAR]: Invalid character in header content ["Overlord-job.type"]
at ClientRequest.setHeader (_http_outgoing.js:488:3)
at new ClientRequest (_http_client.js:221:14)
at Proxy.request (http.js:44:10)
at Proxy.js:552:34
Let's try to add reliable support for passing regexes to DUT overlord:
-
Rename
Overlord-job.typeoption toOverlord-job-type-regex -
Adjust ProxyOverlord::_remoteCall() to handle options with names ending with
-regexspecially:
- Validate that the passed value is a regex from Javascript point of view. If we can demand RegExp objects as values, we should!
- Encode values using the simplest standard HTTP-safe and, ideally, human-reader-friendly encoding you can find; we must preserve things like backslashes, commas, and spaces (all are HTTP-unsafe). The encoding should be "natively" supported by Javascript and Perl -- we do not want to add packages/dependencies OR implement decoders/encoders.
- Adjust the Perl script in a similar fashion:
- decode
-regexvalues - validate that each decoded value is a regex from Perl point of view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.