Use mcmetadata.urls.is_non_news_domain, remove storyapp.non_news_fqdn#437
Open
philbudne wants to merge 1 commit intomediacloud:mainfrom
Open
Use mcmetadata.urls.is_non_news_domain, remove storyapp.non_news_fqdn#437philbudne wants to merge 1 commit intomediacloud:mainfrom
philbudne wants to merge 1 commit intomediacloud:mainfrom
Conversation
Function was copied to mcmetadata some time ago for use by rss-fetcher!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function was copied to mcmetadata some time ago for use by rss-fetcher, so eliminate the local version!
[NOTE! Direct use of the NON_NEWS_DOMAINS list exists in the Scrapy-er, but since it isn't using the function, I left them alone]