fix: prestart.sh loaddata re-runs on every container restart#1502
Open
ayanaoide wants to merge 1 commit intomediacms-io:mainfrom
Open
fix: prestart.sh loaddata re-runs on every container restart#1502ayanaoide wants to merge 1 commit intomediacms-io:mainfrom
ayanaoide wants to merge 1 commit intomediacms-io:mainfrom
Conversation
fix: prestart.sh loaddata re-runs on every container restart manage.py shell outputs extra lines to stdout in non-interactive mode (e.g. "44 objects imported automatically"), causing the exact string comparison with "True" to always fail. Pipe through 2>/dev/null | tail -1 to discard noise and extract only the actual True/False value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When deploying with Docker,
fixtures/categories.jsonand other loaddata fixtures are re-imported on every container restart, even on existing installations. This causes deleted sample data (e.g. default categories) to reappear after each restart.Root Cause
prestart.shdetects existing installations with an exact string comparison:When
manage.py shellruns in non-interactive (pipe) mode, it outputs extra lines to stdout before the actual result:So
$EXISTING_INSTALLATIONcontains two lines and is never equal to"True"— the condition always fails, and the script treats every restart as a fresh installation.Reproduced with:
Output:
Fix
Redirect stderr to
/dev/nulland pipe throughtail -1to extract only the last line, leaving the original= "True"comparison intact:Minimal change — only
2>/dev/null | tail -1is added. No logic is altered.Testing