This repository was archived by the owner on Feb 5, 2022. It is now read-only.
Old md-cloud fixes that should better go to master#97
Open
pereferrera wants to merge 7 commits intomasterfrom
Open
Old md-cloud fixes that should better go to master#97pereferrera wants to merge 7 commits intomasterfrom
pereferrera wants to merge 7 commits intomasterfrom
Conversation
added 7 commits
August 23, 2021 10:11
pereferrera
commented
Jan 20, 2022
| retry_state.outcome)) | ||
|
|
||
|
|
||
| def is_operational_error(e): |
Contributor
Author
There was a problem hiding this comment.
I had to fix this in order to properly catch Psql operational errors
pereferrera
commented
Jan 20, 2022
| signal.signal(signal.SIGINT, self.exit_gracefully) | ||
| signal.signal(signal.SIGTERM, self.exit_gracefully) | ||
| try: | ||
| signal.signal(signal.SIGINT, self.exit_gracefully) |
Contributor
Author
There was a problem hiding this comment.
These lines can only be executed if you instantiate the daemons in the main execution thread, but that is not the case in md_cloud_compute
pereferrera
commented
Jan 20, 2022
| # (see https://docs.sqlalchemy.org/en/latest/orm/session_transaction.html) # noqa: 501 | ||
| t = self._get_transaction_or_raise_exception(id_) | ||
| self.session.commit() | ||
| return t |
Contributor
Author
There was a problem hiding this comment.
I think here the lifecycle was not handled properly so I got errors (but in sqlite it doesn't matter because there are no connections)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.