#537588 add options to load some URLs in the webview#397
#537588 add options to load some URLs in the webview#397jkuester merged 4 commits intomedic:masterfrom
Conversation
jkuester
left a comment
jkuester
left a comment
There was a problem hiding this comment.
@icrc-fdeniger I have pushed a commit that moves the logic up to the UrlHandler. (See my inline comment for the reason.) Let me know if you see any problems with that and if that functionality still works on your end. If all that is good, I think we can ship this! 👍
| return isUrlRelated(appUrl, uriToTest.toString()); | ||
| String uriToTestString = uriToTest.toString(); | ||
| return isUrlRelated(appUrl, uriToTestString) | ||
| || (uriToTestString.contains("redirect_uri="+ Uri.encode(appUrl)+Uri.encode("/medic/login/oidc"))); |
There was a problem hiding this comment.
I am a bit worried about unintended consequences of including this logic down here in the generic isUrlRelated function. This function also gets called via isValidNavigationUrl when the app is closed (as part of the logic to save the user's current url to open next time). If the app gets closed during the middle of an OIDC login flow, I don't think we want to save that URL.
There was a problem hiding this comment.
thanks @jkuester all good for me with your improvements.
|
@lorerod can you also give these changes a go and see if find any issues? 🙏 |
|
Hi @jkuester, @icrc-fdeniger , Here are videos of two tests conducted on my Galaxy A01 Core (Android 10): Login with SSO when already logged in to Keycloakscenario2.movLogin with SSO when not logged in to Keycloakscenario1.movThis work looks good to me. Approving now. |
lorerod
left a comment
lorerod
left a comment
There was a problem hiding this comment.
Left a comment with my test findings. This work looks great. Thank you @icrc-fdeniger.
3 participants
add options to load some URLs in the webview
should fix #396