Skip to content

fix: log intent response data when external app fails#410

Merged
andrablaj merged 11 commits intomasterfrom
external_app
Nov 28, 2025
Merged

fix: log intent response data when external app fails#410
andrablaj merged 11 commits intomasterfrom
external_app

Conversation

@jkuester
Copy link
Copy Markdown
Contributor

@jkuester jkuester commented Jul 25, 2025

This PR is intended for merging the generally applicable functionality from #398. (The remaining changes in #398 are specific to the HealthPulse integration and should not be merged into the main code-base at this time.)

Specifically this PR adds support for:

  • Serializing Boolean values on intents for external apps based on the String "true" and "false" values. ODK does not have a boolean datatype so boolean values are always recorded in ODK forms as string values.
  • Include the data contents (if any) in the log message for failed intent responses. This will just help with debugging in case the failed intent response contains any error data.

@jkuester jkuester requested a review from Benmuiruri July 25, 2025 21:59
@jkuester jkuester self-assigned this Aug 28, 2025
Copy link
Copy Markdown

@Benmuiruri Benmuiruri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@andrablaj andrablaj merged commit 032b571 into master Nov 28, 2025
8 checks passed
@andrablaj andrablaj deleted the external_app branch November 28, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants