chore(#10546): add constant for contact document type#10614
Open
akshaypatra00 wants to merge 1 commit intomedic:masterfrom
Open
chore(#10546): add constant for contact document type#10614akshaypatra00 wants to merge 1 commit intomedic:masterfrom
akshaypatra00 wants to merge 1 commit intomedic:masterfrom
Conversation
Contributor
|
@akshaypatra00 - sorry this issue didn't get a review! I've reached out to an engineer who should follow up soon. |
dianabarsan
requested changes
Mar 4, 2026
Member
dianabarsan
left a comment
dianabarsan
left a comment
There was a problem hiding this comment.
Good start. I added a comment about the webapp offline user view map not being able to require things.
Also, if I search the codebase by 'contact', I am finding a LOT of occurrences. All relevant ones should be changed in this PR.
| @@ -1,14 +1,15 @@ | |||
| module.exports.map = (doc) => { | |||
| const skip = [ '_id', '_rev', 'type', 'refid', 'geolocation' ]; | |||
| const { DOC_TYPES } = require('@medic/constants'); | |||
Member
There was a problem hiding this comment.
CouchDb view maps can't require unfortunately. So this file shouldn't be changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a shared constant for the
contactdocument type and replaceshard-coded usages with the new constant. This improves consistency and
maintainability by avoiding repeated string literals across the codebase.
Fixes #10546
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.