Skip to content

Conversation

@Shai1-Levi
Copy link

Why we need this PR

Currently NMO Makefile creates a db-based catalog, which was deprecated

Changes made

This change create a file-based catalog

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-2556

Test plan

  • Create the file-based catalog and push it to my quay.io repository via Makefile
  • Create a CatalogSource pointing to the new catalog
  • Install NMO via WebUI, verify that everything works

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2025

Hi @Shai1-Levi. Thanks for your PR.

I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@razo7
Copy link
Member

razo7 commented Jan 29, 2025

/ok-to-test

$(OPM) init ${OPERATOR_NAME} \
--default-channel=${CHANNELS} \
--description=./README.md \
--icon=${BLUE_ICON_PATH} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLUE_ICON_PATH isn't defined. In your testing after installation from the catalog is there an icon? @Shai1-Levi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR, there was no icon in the catalog. I will add this change also to FAR

@razo7
Copy link
Member

razo7 commented Jan 29, 2025

/retest

1 similar comment
@razo7
Copy link
Member

razo7 commented Feb 11, 2025

/retest

@Shai1-Levi Shai1-Levi changed the title [WIP]Build a file-based catalog Build a file-based catalog Feb 12, 2025
@razo7
Copy link
Member

razo7 commented Feb 12, 2025

/approve
/lgtm
Thanks for adding the FBC support and waiting for the fix of e2e at #144 @Shai1-Levi

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7, Shai1-Levi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9f1d95d into medik8s:main Feb 12, 2025
23 checks passed
@razo7
Copy link
Member

razo7 commented Feb 17, 2025

/cherry-pick release-0.18

@openshift-cherrypick-robot

@razo7: new pull request created: #145

Details

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants