-
Notifications
You must be signed in to change notification settings - Fork 19
Build a file-based catalog #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @Shai1-Levi. Thanks for your PR. I'm waiting for a medik8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
| $(OPM) init ${OPERATOR_NAME} \ | ||
| --default-channel=${CHANNELS} \ | ||
| --description=./README.md \ | ||
| --icon=${BLUE_ICON_PATH} \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLUE_ICON_PATH isn't defined. In your testing after installation from the catalog is there an icon? @Shai1-Levi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See similar changes at MDR FBC PR https://github.com/medik8s/machine-deletion-remediation/pull/123/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIR, there was no icon in the catalog. I will add this change also to FAR
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, Shai1-Levi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.18 |
|
@razo7: new pull request created: #145 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Currently NMO Makefile creates a db-based catalog, which was deprecated
Changes made
This change create a file-based catalog
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-2556
Test plan