Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the haptic_feedback package to leverage recent improvements including HD vibrations on Android 11+ and better handling of system haptic settings.
- Updated
haptic_feedbackdependency from version 0.5.1+1 to 0.6.4+2 - Added
usage: HapticsUsage.mediaparameter to the haptic vibration call to respect user preferences for touch haptics vs. media haptics
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pubspec.yaml | Bumps the haptic_feedback package version to 0.6.4+2 to access new features and improvements |
| lib/views/end_screen/end_screen_view.dart | Adds the usage parameter set to media for the success haptic feedback on the end screen |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that this is a popular app using my package
haptic_feedback.Recently I've made some substantial improvements which will come with this PR:
Android 13+ users who have disabled touch haptics in system settings didn't get haptics from the app. This change sets the usage type to
media(before it wasunknown, which defaults totouch). If vibrations are indeed supposed to be disabled when the user opts out from touch haptics, we can remove the usage argument, or set it to touch.On Android 11+ the plugin can now use HD vibrations which feel much better and smoother
Android 7.* devices now vibrate with the correct pattern
https://pub.dev/packages/haptic_feedback/changelog