feat(pipeline): implement FHIR validation pipeline step#200
Open
feat(pipeline): implement FHIR validation pipeline step#200
Conversation
6f0650f to
c4a93a1
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 84.68% 84.73% +0.04%
==========================================
Files 46 48 +2
Lines 4773 5167 +394
==========================================
+ Hits 4042 4378 +336
- Misses 567 603 +36
- Partials 164 186 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4dd8415 to
88d2098
Compare
d272df2 to
d0a07f7
Compare
d0a07f7 to
0927b63
Compare
juliangruendner
previously approved these changes
Mar 9, 2026
0927b63 to
22f310e
Compare
juliangruendner
previously approved these changes
Mar 10, 2026
- Add validation step that sends FHIR resources to a validation service - Chunk resources into Bundles with configurable size and concurrency - Write per-file OperationOutcome reports for all validation results - Default fail_on_error to true (stop pipeline on data quality errors) - Support resumption by skipping files with existing reports - Add fullUrl to inner Bundle entries for proper reference resolution
22f310e to
76e3899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/validateResource*.validation.ndjson) injobs/<job-id>/validation/and fails the step if any resource has error-level or fatal-level issuesmax_concurrent_requests, default: 4), resumption (skips files with existing reports), and transparent step semantics (subsequent steps look past validation to find their input data)Configuration
New files
internal/services/validation_client.go— HTTP client for FHIR validation serviceinternal/pipeline/validation.go—ExecuteValidationStepwith concurrent validationtests/unit/validation_client_test.go— 9 client unit teststests/unit/pipeline_validation_test.go— 10 pipeline step unit testsModified files
internal/models/config.go— AddedValidationConfigstructinternal/services/config.go— Added validation config loadinginternal/services/state.go— Added validation to dirs, unifiedGetStepInputDirinto a single backwards walkinternal/models/validation.go— Added validation step to service URL checkscmd/pipeline.go— Replaced stub with realExecuteValidationStepcallCloses #7