Skip to content

fix(core-flows): avoid overriding customer and region from setPricingContext hook result #14022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Nov 17, 2025
Merged

fix(core-flows): avoid overriding customer and region from setPricingContext hook result #14022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
997011e
Avoid overriding region and customer from pricing context hook result…
NicolasGorga Nov 10, 2025
c2faa23
Add changeset
NicolasGorga Nov 10, 2025
3b1036b
Merge branch 'develop' into fix/avoid-overrides-pricing-context-hook
olivermrbl Nov 12, 2025
010da73
Merge branch 'develop' into fix/avoid-overrides-pricing-context-hook
olivermrbl Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smart-stamps-shake.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@medusajs/core-flows": patch
---

fix(core-flows): avoid overriding customer and region from setPricingContext hook result
4 changes: 2 additions & 2 deletions packages/core/core-flows/src/cart/workflows/get-variants-and-items-with-prices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,12 @@ export const getVariantsAndItemsWithPrices = createWorkflow(
const cart = data.cart
const baseContext = {
...filterObjectByKeys(cart, cartFieldsForPricingContext),
customer: cart.customer,
region: cart.region,
Copy link

@cursor cursor bot Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Pricing Context Ignores Custom Objects

After allowing setPricingContextResult to provide custom region and customer objects, the code still uses cart.region?.currency_code, cart.region_id, and cart.customer_id as fallbacks. This creates inconsistency when a custom region or customer is provided, causing the context to have mismatched IDs and currency codes that don't match the custom objects.

Fix in Cursor Fix in Web

...(data.setPricingContextResult ? data.setPricingContextResult : {}),
currency_code: cart.currency_code ?? cart.region?.currency_code,
region_id: cart.region_id,
region: cart.region,
customer_id: cart.customer_id,
customer: cart.customer,
}

return (data.items ?? cart.items ?? [])
Expand Down