Add ZoneProfilers support #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for ZoneProfilers to enable detailed performance profiling of simulations, and refactors the codebase to improve maintainability.
- Introduces
RunStatestruct to encapsulate simulation state (RNG, step, state, SHA256, trajectory path) - Adds optional
profilerparameter throughout the codebase withNullProfiler()default for zero overhead - Refactors duplicated simulation loop code into reusable
do_a_step!andinit_run_statefunctions
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/run-sim.jl | Adds RunState struct and refactors simulation functions to accept profiler parameter; consolidates duplicated loop logic |
| src/file-saving.jl | Updates write_traj_file to return SHA256 hash and adds profiler instrumentation |
| src/MEDYANSimRunner.jl | Consolidates imports from individual files and adds ZoneProfilers dependency |
| src/outputdiff.jl | Removes redundant imports now in main module file |
| README.md | Adds documentation for ZoneProfilers integration with usage examples |
| Project.toml | Adds ZoneProfilers dependency, updates Julia version to 1.12, reorganizes workspace config |
| .github/workflows/CI.yml | Updates CI to test Julia 1.12 instead of 1.11 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, generally refactor things. https://github.com/nhz2/ZoneProfilers.jl