CV2-6701: Check newsletter: add limits#2419
Merged
Conversation
caiosba
requested changes
Apr 8, 2026
Contributor
caiosba
left a comment
There was a problem hiding this comment.
Thanks, Sawy! From my side, the only blocker is the each / find_each thing. Did you test the migration locally? Were you able to cover all 3 cases with the data you have in your local database?
Contributor
Author
Yes Caio |
caiosba
approved these changes
Apr 8, 2026
Contributor
caiosba
left a comment
There was a problem hiding this comment.
Thanks for addressing the change requests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add controls and limits to the newsletter feature due to new costs:
Add two new fields to Team.settings:
Add a migration rake task to enable the newsletter feature for:
References: CV2-6701
How to test?
Implement unit tests
Checklist