Skip to content

Improve workflow action for deployment #2396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sonoransun wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

Improve workflow action for deployment #2396

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fec8a8a
Syntax fixes and determine task name by merge target.
Jul 25, 2025
b0d0edc
Use current version of checkout.
Jul 25, 2025
6341477
Dependency update.
Jul 27, 2025
c22518d
Syntax fix.
Jul 27, 2025
2ca079e
Invoke for this branch.
Jul 27, 2025
8f2e5c1
Use develop upstream for builds from this branch.
Jul 27, 2025
4fa8c43
Use develop upstream for builds from this branch.
Jul 27, 2025
f409a05
Call sysops for deployment.
Jul 28, 2025
cfa9961
Remove temporary hack for build and deploy from this branch.
Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 12 additions & 39 deletions .github/workflows/ci-deploy-env.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ on:
branches:
- 'develop'
- 'master'
- '*deploy/*'

jobs:
build-test-deploy:
Expand All @@ -14,10 +13,10 @@ jobs:
outputs:
image: ${{ steps.build-image.outputs.image }}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Configure AWS Credentials
uses: aws-actions/configure-aws-credentials@v1
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down Expand Up @@ -83,41 +82,15 @@ jobs:
--file ./production/Dockerfile \
--build-arg DEPLOY_BRANCH=$BRANCH ./

- name: Download current task definition
- name: Kick off Terraform deploy in sysops/
id: sysops-deploy
if: github.event_name == 'push' && startsWith(github.ref, 'refs/heads/main')
run: |
# TODO: switch env based on branch, only for develop or master.
TASKDEF=qa-check-web
aws ecs describe-task-definition \
--task-definition $TASKDEF --query taskDefinition \
> task-definition.json

- name: Update task definition
id: task-update-in-ecs
uses: aws-actions/amazon-ecs-render-task-definition@v1
with:
task-definition: task-definition.json
container-name: qa-check-web-c
image: ${{ steps.push-image-to-ecr.outputs.image }}

- name: Deploy new ECS task definition
uses: aws-actions/amazon-ecs-deploy-task-definition@v2
with:
task-definition: ${{ steps.task-update-in-ecs.outputs.task-definition }}
service: qa-check-web
cluster: ecs-qa
wait-for-service-stability: true


# - name: Kick off Terraform deploy in sysops/ if not live
# id: sysops-deploy
# run: |
# BRANCH=$(echo "${GITHUB_REF#refs/*/}" | sed 's/.*\///')
# if [[ "$BRANCH" != master ]]; then
# curl \
# -X POST \
# -H "Accept: application/vnd.github.v3+json" \
# https://api.github.com/repos/meedan/sysops/actions/workflows/deploy_${{ github.event.repository.name }}.yml/dispatches \
# -u ${{ secrets.SYSOPS_RW_GITHUB_TOKEN }} \
# -d '{"ref": "master", "inputs": {"git_sha": "${{ github.sha }}", "branch": "'$BRANCH'"}}'
# fi
curl --fail-with-body \
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{ secrets.SYSOPS_RW_GITHUB_TOKEN }}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/meedan/sysops/actions/workflows/deploy_${{ github.event.repository.name }}.yml/dispatches \
-d '{"ref": "master", "inputs": {"git_sha": "${{ github.sha }}", "type": "push"}}'

Loading