Open
Conversation
Fixing up UPdate Better safety More thorough checking during parsing Better options More checking More checking More checking Less warnuings Update Update Update BEtter Cleaner Fixing Fixing Update Update
Make emscripten build work Should be fixed Making progress This actually compiles now Build Fixing
msoos
force-pushed
the
new-strategy-system
branch
from
837b2fd to
500a36c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new strategy system that allows us to write strategies such as:
"learn(samples=1,max_repairs=80),learn(max_repairs=400),bveThe last strategy runs forever, the others until max_repairs. max_repairs must be set for all strategies except the last one. The parameters can be overridden at toplevel with e.g.
--bwequalwhich sets the default. You can then override them per-strategy, puttingbwequal=xinside the bracket, and that will override it for that particular strategy.This PR also fixes the parsing of all parameters in the main.cpp. It now correctly validates the types of the parameters, so if 0.1 is given for an int, it will error out. So we are much more careful now.
Let me know what you think.