Open
Conversation
added 2 commits
May 5, 2024 12:18
Owner
|
yo, I don't really look at pool requests because it's harder for me to maintain the code like this, thanks for the help tho and if you want to help some more in the future you can message me on discord and we can exchange ideas 💪 tag me there, I'm low level game dev |
Owner
|
and yes I would need to remake structures big time 😆 |
meemknight
force-pushed
the
master
branch
5 times, most recently
from
922df8f to
0caa463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed repeating code + a bit of a refactor so it's easier to build upon without repeating code over and over, when you need to generate additional structures u can just add to the map, and the path to the structure in the header file.
I think it can be further refactored by recursively parsing the directories rather than including them each 1 by 1, this way people can also just mod structures without adding any code (but it'd require a lot of refactoring)
structurePaths could also just be a const char array I guess.