refactor(calendarEvents): rework search events + add search for account level#183
Merged
GuillaumeDecMeetsMore merged 10 commits intomasterfrom Jan 23, 2025
Conversation
Base automatically changed from
guillaume/feat/calendar-event-add-event-type
to
master
January 21, 2025 09:49
…d-add-account-search-events
…d-add-account-search-events
GuillaumeDecMeetsMore
changed the title
Collaborator
Author
There was a problem hiding this comment.
Most interesting struct here (1)
Collaborator
Author
There was a problem hiding this comment.
Most interesting struct here (2)
Collaborator
Author
There was a problem hiding this comment.
Most interesting struct here (3)
mm-zacharydavison
previously approved these changes
Jan 22, 2025
crates/domain/src/shared/id_query.rs
Outdated
| pub eq: Option<ID>, | ||
|
|
||
| /// Optional ID (inequality test) | ||
| /// If "eq" is provided, this field is ignored |
There was a problem hiding this comment.
This might not be possible because of the rust -> ts types translation, but if I was designing this from a type-perspective in TS, I would make IdQuery a union type of a few different types, such that eq cannot co-exist with other options.
If it's messy / hard to do in rust -> ts, ignore this.
Collaborator
Author
There was a problem hiding this comment.
Good point, it's likely possible, let me check 👍
mm-zacharydavison
previously approved these changes
Jan 22, 2025
mm-zacharydavison
left a comment
mm-zacharydavison
left a comment
There was a problem hiding this comment.
Approved if i'm wrong about the comments:
…d-add-account-search-events
mm-zacharydavison
approved these changes
Jan 22, 2025
GuillaumeDecMeetsMore
deleted the
guillaume/refactor/rework-search-events-and-add-account-search-events
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
Notes