Skip to content

fix(recurring until): don't change recurring until and include last instance#386

Closed
GuillaumeDecMeetsMore wants to merge 1 commit intomasterfrom
guillaume/fix/recurring-until-shouldnt-change-and-should-include-last-instance
Closed

fix(recurring until): don't change recurring until and include last instance#386
GuillaumeDecMeetsMore wants to merge 1 commit intomasterfrom
guillaume/fix/recurring-until-shouldnt-change-and-should-include-last-instance

Conversation

@GuillaumeDecMeetsMore
Copy link
Collaborator

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore commented Sep 1, 2025

Changed

  • Fix recurring_until not reset when recurring is reset
  • Fix recurring_until modified when it's set - better to keep the value we receive, and instead do the following ⬇️
  • Fix recurring_until not being inclusive for all queries
    • If a recurring event has a recurring_until that goes until the start of the timespan we are searching (e.g. we are searching from 07/20 00:00 to 07/27 00:00, and the recurring event is everyday at 00:00 for 1h with a recurring_until at 07/20 00:00, then we should include the recurring event as the last instance 07/20 00:00 => 07/20 01:00 should be generated)
    • https://datatracker.ietf.org/doc/html/rfc5545 ("The UNTIL rule part defines a DATE or DATE-TIME value that bounds
      the recurrence rule in an inclusive manner.")

Edit: this doesn't work as, if we are searching from 07/20 00:30 to 07/27 00:30, we are missing the recurring event, even though there are 30minutes still impacting our time range...

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore self-assigned this Sep 1, 2025
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as ready for review September 1, 2025 07:27
@GuillaumeDecMeetsMore GuillaumeDecMeetsMore marked this pull request as draft September 1, 2025 07:37
@GuillaumeDecMeetsMore
Copy link
Collaborator Author

Closing

@GuillaumeDecMeetsMore GuillaumeDecMeetsMore deleted the guillaume/fix/recurring-until-shouldnt-change-and-should-include-last-instance branch September 29, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant