fix(recurring until): don't change recurring until and include last instance#386
Closed
GuillaumeDecMeetsMore wants to merge 1 commit intomasterfrom
Conversation
Collaborator
Author
|
Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
recurring_untilnot reset whenrecurringis resetrecurring_untilmodified when it's set - better to keep the value we receive, and instead do the following ⬇️recurring_untilnot being inclusive for all queriesrecurring_untilthat goes until the start of the timespan we are searching (e.g. we are searching from 07/20 00:00 to 07/27 00:00, and the recurring event is everyday at 00:00 for 1h with arecurring_untilat07/20 00:00, then we should include the recurring event as the last instance07/20 00:00=>07/20 01:00should be generated)the recurrence rule in an inclusive manner.")
Edit: this doesn't work as, if we are searching from 07/20 00:30 to 07/27 00:30, we are missing the recurring event, even though there are 30minutes still impacting our time range...