Skip to content

Conversation

@kinderjoypresents
Copy link

Summary

This PR prevents mega-evme from panicking when --log.file points to an invalid/unwritable path.

Changes

  • Replace expect() on std::fs::File::create with graceful error handling.
  • On failure, print a short message to stderr and fall back to stderr logging.

Motivation

Passing an invalid --log.file path should not crash the CLI; it should continue running with stderr logging.

Copy link
Collaborator

@Troublor Troublor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kinderjoypresents
Copy link
Author

LGTM, thanks!

Do I need to update the file so you can merge it?

@Troublor
Copy link
Collaborator

@kinderjoypresents The CI workflow is currently misconfigured for external PRs. We will fix that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants